Skip to content

Helm Charts Model Registry #3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 30, 2025
Merged

Helm Charts Model Registry #3175

merged 6 commits into from
Jun 30, 2025

Conversation

kunal-511
Copy link
Contributor

@kunal-511 kunal-511 commented Jun 29, 2025 •
edited
Loading

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Helm Charts For Model Registry

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@kunal-511
Helm Charts Model Registry
3e1303c 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
Copy link
Contributor Author

cc: @juliusvonkohout

@kunal-511
Fixed lint and typo error
a414022 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@juliusvonkohout
Copy link
Member

cc: @juliusvonkohout

The test is failing

kunal-511 added 2 commits June 30, 2025 16:58
@kunal-511
Fixed the helm values
4a5c24f 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
Updated the values and helper
f76e897 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
Copy link
Contributor Author

cc: @juliusvonkohout

The test is failing

Yes now it is green
I have updated

juliusvonkohout
juliusvonkohout reviewed Jun 30, 2025
View reviewed changes
tests/compare_all_scenarios.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/helm_compare_all_scenarios and please rename the other files as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

kunal-511 added 2 commits June 30, 2025 18:52
@kunal-511
Files renamed
69b4a12 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
path updated in the gha
34cd4fe 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@juliusvonkohout
Copy link
Member

thank you

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jun 30, 2025
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ad65081 into kubeflow:master Jun 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusvonkohout juliusvonkohout juliusvonkohout left review comments

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

Assignees

@juliusvonkohout juliusvonkohout

Labels

approved lgtm size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kunal-511 @juliusvonkohout